Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor deadman set failmode to be cross platform #9670

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Refactor deadman set failmode to be cross platform #9670

merged 1 commit into from
Dec 5, 2019

Conversation

mattmacy
Copy link
Contributor

@mattmacy mattmacy commented Dec 3, 2019

Signed-off-by: Matt Macy [email protected]

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@mattmacy mattmacy force-pushed the projects/spa_misc_resolve branch from 9474c08 to 76c51b1 Compare December 3, 2019 22:27
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Dec 3, 2019
behlendorf
behlendorf requested changes Dec 3, 2019
View reviewed changes
@mattmacy mattmacy force-pushed the projects/spa_misc_resolve branch from 76c51b1 to 62e5ae6 Compare December 4, 2019 00:14
@behlendorf behlendorf requested a review from lundman December 4, 2019 00:16
lundman
lundman approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@lundman lundman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I have this deadman code at all, but it looks fine :)

@behlendorf behlendorf self-requested a review December 4, 2019 19:23
@mattmacy mattmacy force-pushed the projects/spa_misc_resolve branch from 62e5ae6 to 457d4ca Compare December 4, 2019 22:17
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 4, 2019
@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #9670 into master will decrease coverage by <1%.
The diff coverage is 75%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #9670    +/-   ##
========================================
- Coverage      79%      79%   -<1%     
========================================
  Files         418      418            
  Lines      123562   123561     -1     
========================================
- Hits        98093    97884   -209     
- Misses      25469    25677   +208
Flag Coverage Δ
#kernel 80% <75%> (ø) ⬇️
#user 67% <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12395c7...457d4ca. Read the comment docs.

@behlendorf behlendorf merged commit e64e84e into openzfs:master Dec 5, 2019
@mattmacy mattmacy deleted the projects/spa_misc_resolve branch December 19, 2019 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@lundman lundman lundman approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattmacy @behlendorf @lundman